Support ad-hoc filtering of directives #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directives currently have no-op
filter
method that was added to support extraction of parameter directive tuples. This pull request moves filter functionality to aFilterDirective
subtype so that the potentially surprising behavior of a no-op filter is now limited to and-ed parameter directives.Further, these changes allow us to support proper filtering in cases where
orElse
is used. We can now construct a directive that knows how to fail for some conditions, and add more failure conditions via theif
clause of a for expression. This behavior is demonstrated in an example added toDirectiveSpec
.